Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Swahili RGL grammars #106

Closed
heatherleaf opened this issue Dec 20, 2018 · 2 comments · Fixed by #341
Closed

Two Swahili RGL grammars #106

heatherleaf opened this issue Dec 20, 2018 · 2 comments · Fixed by #341

Comments

@heatherleaf
Copy link
Member

Since the adoption of PR #32 the RGL now contains two Swahili grammars -- swahili and kiswahili.

I think this is a problem, how can it be tackled?

@heatherleaf
Copy link
Member Author

See this comment by @johnjcamilleri: #105 (comment)

For Swahili, I think there should be a single folder swahili which uses the proper ISO code Swa.
Then if one of the two implementations is to be deprecated then put that in swahili/old or similar, and document this in swahili/README.md.

If the two implementations should really both be considered active (which is doubtful) then they should be in swahili/v1 and swahili/v2, use the same ISO code, and you need to devise some way of choosing which one gets compiled by the RGL build script, e..g using symlinks. But this is less desirable.

@inariksit
Copy link
Member

PR #341 fixes this in the way John suggested.

@inariksit inariksit linked a pull request Jun 5, 2020 that will close this issue
@inariksit inariksit mentioned this issue Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants