Better history functions & fix bug with sync add_entity call #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Your PR is very welcome 🙏. I think removing *arts and **kwargs will save future devs some headaches lol. I have a few questions that I'm curious about and then we can merge it. Thoughts? |
|
Hello! |
|
Friendly ping :) |
|
In my review I had some questions on a few small things. After we talk about those then I can merge it! |
|
Ah there we go. |
GrandMoff100
approved these changes
Jun 15, 2022
|
Here we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to play with history functions and have found that *args & **kwargs are not the best friends of mine :)
Also fixed small bug with
add_entitycall.