Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unclosed Sessions #133

Merged
merged 3 commits into from Nov 25, 2022
Merged

Fix Unclosed Sessions #133

merged 3 commits into from Nov 25, 2022

Conversation

GrandMoff100
Copy link
Owner

Due to some tricky super() stuff the init code for RawAsyncClient was getting run for RawClient. By directly calling the parent init we solved this trickiness.

@GrandMoff100
Copy link
Owner Author

GrandMoff100 commented Nov 25, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.09s
✅ CREDENTIALS secretlint yes no 0.99s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 0.93s
✅ JSON jsonlint 2 0 0.57s
✅ JSON prettier 2 0 0 0.54s
✅ JSON v8r 2 0 2.73s
✅ MARKDOWN markdownlint 5 0 0 0.38s
✅ MARKDOWN markdown-link-check 5 0 2.66s
✅ MARKDOWN markdown-table-formatter 5 0 0 0.27s
✅ SPELL misspell 27 0 0 0.06s
✅ YAML prettier 8 0 0 0.79s
✅ YAML v8r 8 0 11.49s
✅ YAML yamllint 8 0 0.23s

See errors details in artifact MegaLinter reports on CI Job page

@GrandMoff100
Copy link
Owner Author

Closes #127

@GrandMoff100 GrandMoff100 linked an issue Nov 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #133 (c75d12d) into dev (816011c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c75d12d differs from pull request most recent head 7e064a0. Consider uploading reports for the commit 7e064a0 to get more accurate results

@@            Coverage Diff            @@
##               dev      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          948       949    +1     
=========================================
+ Hits           948       949    +1     
Impacted Files Coverage Δ
tests/conftest.py 100.00% <ø> (ø)
tests/test_client.py 100.00% <ø> (ø)
tests/test_errors.py 100.00% <ø> (ø)
homeassistant_api/client.py 100.00% <100.00%> (ø)
homeassistant_api/rawasyncclient.py 100.00% <100.00%> (ø)
homeassistant_api/rawclient.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GrandMoff100 GrandMoff100 merged commit bf07f57 into dev Nov 25, 2022
@GrandMoff100 GrandMoff100 deleted the fix-unclosed-session branch June 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclosed client session when using inside function
1 participant