Malformed entity id. Broken get_state API

[bramstroker]

Calling get_state will always result in a malformed entity_id error.

state = self.client.get_state(self._entity_id)
File "/usr/local/lib/python3.8/site-packages/homeassistant_api/client.py", line 207, in get_state
raise MalformedInputError(f"The entity_id, {entity_id!r}, is malformed")
homeassistant_api.errors.MalformedInputError: The entity_id, 'light.amirlight', is malformed

I have pinpointed the problem to be in the malformed_id function. https://github.com/GrandMoff100/HomeAssistantAPI/blob/master/homeassistant_api/client.py#L123

The 4th check here entity_id.lower() == entity_id will always evaluate to True, causing the malformed checker to return True.
This should be entity_id.lower() != entity_id imo.

The bug must be introduced in the latest version as it was working fine for me before.

[GrandMoff100]

Oh, lol!

Time for post version 2
I also wanna see who changed this lol.

Thanks for informing me about this!

[GrandMoff100]

New release coming in a few minutes.

[GrandMoff100]

Fixed in version 2.4.0.post2! 🎉

[bramstroker]

Thanks for the quick resolution. Working fine now!

[alin23]

@GrandMoff100 This seems to still be an issue: c02ed22#diff-f0d7153844b6a2b579d596a0a7d65df788a7c318a72a4c206f2f29c8123f3b71R60

[GrandMoff100]

Interesting

[alin23]

It's easy to miss something like this in a large diff created by linting/formatting :)

[GrandMoff100]

Oh whoops, this is a valid issue. And seeing as I don't think this function is implemented anywhere that why I think this has gone unnoticed. But luckily I think I know just the spot to implement that function!

I should have this fixed in a few minutes.

[alin23]

Maybe it's better to just .lower() the entity_id forcefully for passing it to the API, instead of throwing an error. It would make for a better user experience even for less experienced devs that aren't aware of the casing requirements

[GrandMoff100]

Good idea.

[GrandMoff100]

Maybe it would also be a good idea to add entity_id structure to the docs.