Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy Fix - Locations Component #203

Merged
merged 4 commits into from Aug 5, 2023
Merged

Snappy Fix - Locations Component #203

merged 4 commits into from Aug 5, 2023

Conversation

GrantBirki
Copy link
Owner

Snappy Fix

this is more of a work-around than a "fix"

This pull request removes the locations component from the main page since it is "jumpy". I am not sure why, but when scrolling around the locations component, (only downwards) it causes the page to jump farther down like someone bumped your scroll bar. By putting the locations component on its own page, this is no longer an issue.

@GrantBirki GrantBirki added the bug Something isn't working label Aug 5, 2023
@GrantBirki GrantBirki self-assigned this Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of the deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  4. 🎉 Merge!

If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@GrantBirki GrantBirki changed the title Snappy fix Snappy Fix - Locations Component Aug 5, 2023
@GrantBirki
Copy link
Owner Author

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Deployment Triggered 🚀

GrantBirki, started a branch deployment to github-pages

You can watch the progress here 🔗

Branch: snappy-fix

@github-actions github-actions bot temporarily deployed to github-pages August 5, 2023 11:18 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Deployment Results ✅

GrantBirki successfully deployed branch snappy-fix to github-pages

View Live Deployment 🔗

@GrantBirki GrantBirki merged commit 362ca93 into main Aug 5, 2023
4 checks passed
@GrantBirki GrantBirki deleted the snappy-fix branch August 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant