Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Comment when all validations pass #56

Open
rlh1994 opened this issue Mar 13, 2024 · 2 comments
Open

Feature request: Comment when all validations pass #56

rlh1994 opened this issue Mar 13, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rlh1994
Copy link

rlh1994 commented Mar 13, 2024

Not that important, but sometimes it's nice to have a comment even when all tests have passed, to confirm how many were run without having to check the logs.

@GrantBirki GrantBirki added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2024
@GrantBirki
Copy link
Owner

I think this could be helpful for some use cases but others might find this to be very spammy and add unwanted noise on pull requests. If this feature is to be added, it should be disabled by default and toggled on with comment_on_success: true or something of the sorts

@frottke
Copy link

frottke commented Apr 16, 2024

I would love this feature! please consider adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants