Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Property slider view default unit #1346

Closed
FrciSmrci opened this issue Aug 6, 2018 · 6 comments
Closed

[FEATURE REQUEST] Property slider view default unit #1346

FrciSmrci opened this issue Aug 6, 2018 · 6 comments

Comments

@FrciSmrci
Copy link

Hey @artf ,

I think that the slider component would come handy from the UX perspective for the user interaction of some of the integer properties as well, like font-size / line-height, etc.

I would like to propose that the slider component is extended with a default unit property which would take in an string, but without the selection array under units property.

What do you think?

Thank you in advance!

@artf
Copy link
Member

artf commented Aug 8, 2018

It could be already possible with this kind of configuration

{
        type: 'slider',
        property: 'font-size',
        units: [],
        unit: 'em',
        defaults: 14,
        max: 40,
        min: 1,
}

but unfortunately I notice that currently the slider itself does not update its pointer (due to a not numeric value). I'll fix that in the next release

@FrciSmrci
Copy link
Author

FrciSmrci commented Aug 9, 2018

Thank you @artf :) When is the plan to do the next release?

@FrciSmrci
Copy link
Author

@artf Not sure if this question slipped by.

@artf
Copy link
Member

artf commented Aug 23, 2018

Yeah, sorry, I was too much busy with other stuff this week, hope to release this weekend 😬

@FrciSmrci
Copy link
Author

@artf Awesome, thank you! :)

@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants