Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css Media Query Issue #1506

Closed
YashPrince opened this issue Oct 11, 2018 · 7 comments
Closed

Css Media Query Issue #1506

YashPrince opened this issue Oct 11, 2018 · 7 comments

Comments

@YashPrince
Copy link

YashPrince commented Oct 11, 2018

Hello @artf
There is an issue on demo page as well as library in media query.
Issue is that if user update style on mobile view first and then the tab view then media query do not work for mobile view. If we update style for desktop first, tab second and mobile third then everything works fine
but if we reverse the step mobile view first, tab view second and desktop view third then css/media query
will not work for tab and desktop view.

@media (max-width: 480px) {
    #if70u {
        font-size: 20px;
    }
}

@media (max-width: 992px) {
    #if70u {
        font-size: 40px;
    }
}

I think it was due to 480 should be down and 992 should be above.
Any help would be appreciated, thanks!

@YashPrince
Copy link
Author

@artf Problem is that if we add a style mobile first and then on tab then mobile view css is override by tab view and all the css applied for the mobile view will not apply on the mobile view as it override by tab view.

@YashPrince
Copy link
Author

YashPrince commented Oct 31, 2018

@artf Any Update about this as it's a big issue. User can not update css for tab once they apply for the mobie first. They need to delete and readd that element.

@artf
Copy link
Member

artf commented Nov 3, 2018

@YashPrince PRs are welcome

@artf artf added this to To do in Release 0.14.43 via automation Nov 3, 2018
@artf artf moved this from To do to In progress in Release 0.14.43 Nov 20, 2018
@artf artf closed this as completed in f61b411 Nov 20, 2018
Release 0.14.43 automation moved this from In progress to Done Nov 20, 2018
@Sharsie
Copy link

Sharsie commented May 10, 2019

@artf I think this broke sorting queries with mediaCondition set to min-width, can we check for this in https://github.com/artf/grapesjs/blob/f61b41167fe339a3b96ce7fe183a094be1094fdd/src/code_manager/model/CssGenerator.js#L155 and reverse the sort order?

@artf
Copy link
Member

artf commented May 11, 2019

@Sharsie #1996

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label May 20, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

3 participants