Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Change HTML of Panel buttons from span to button #1787

Closed
ateebahmed opened this issue Feb 11, 2019 · 3 comments
Closed

[Question] Change HTML of Panel buttons from span to button #1787

ateebahmed opened this issue Feb 11, 2019 · 3 comments
Assignees
Labels

Comments

@ateebahmed
Copy link

I have created some Panels and would like to change the element of panel buttons from span to button as its more appropriate and looks better with CSS, how would I configure it?

@artf
Copy link
Member

artf commented Feb 16, 2019

Right now it's not possible, but I'll add this possibility in the next release, so it'll be something like this:

editor.Panels.addButton('PANEL-ID', {
	id: 'test',
	tagName: 'button',
	className: 'someClass',
	command: editor => alert('Test'),
})

@artf artf self-assigned this Feb 16, 2019
@artf artf added this to To do in Release v0.14.55 via automation Feb 16, 2019
@artf artf closed this as completed in 2972a32 Feb 16, 2019
Release v0.14.55 automation moved this from To do to Done Feb 16, 2019
@ateebahmed
Copy link
Author

That'd be great!

@lock
Copy link

lock bot commented Feb 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Feb 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants