Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add category on traits #1806

Closed
WebEtSolutions opened this issue Feb 18, 2019 · 10 comments
Closed

[Feature]: Add category on traits #1806

WebEtSolutions opened this issue Feb 18, 2019 · 10 comments

Comments

@WebEtSolutions
Copy link
Contributor

Hi and thank's for your job !

It's possible to make traits under cateogories like blocks ?
If it's possible, maybe use the Category object like the BlockManager ?

Categories on BlockManager work fine, so if TraitManager add the same system of category, it's perfect !

What it's the best method for you for implements this feature ? We are ready to develop this feature and make PR.

Thank's

@artf
Copy link
Member

artf commented Feb 22, 2019

Hi @WebEtSolutions follow my indications posted on your PR, so if we need to implement the same logic in Traits we have to abstract it from Blocks

@WebEtSolutions
Copy link
Contributor Author

Hi, no problem we will work for this PR.

@WebEtSolutions
Copy link
Contributor Author

Hi,

You can check PR on https://github.com/WebEtSolutions/grapesjs/tree/%231806

We have a question for the PR.

CategoryView and Category are moved on categories folder and BlocksView and TraitsView use the new CategoryView.

Classes for the render of categories change from block-c(category)(no-cat) to items-c(category)(no-cat)

So there are the same code on TraitsView and BlocksView.

What's for you the best way for reformat BlocksView and TraitsView ?

Thank's for your work.

Web&Solutions Team

@Uysim
Copy link

Uysim commented Jan 12, 2020

Do we have this feature yet?

@protozoo
Copy link

Hi there! Is this feature implemented? Would be pretty useful, I have some components with a couple dozen traits. Thanks!

@michaelhofer
Copy link

That would bery very intersting indeed. I am happy to help if necessary :)

@artf artf changed the title [Feature request] Add category on traits [Feature] Add category on traits Aug 10, 2023
@artf artf added feature and removed enhancement labels Aug 10, 2023
@artf artf changed the title [Feature] Add category on traits [Feature]: Add category on traits Aug 10, 2023
@bgrand-ch
Copy link
Contributor

+1

2 similar comments
@vasicvuk
Copy link

+1

@amirrahmani76
Copy link
Contributor

+1

@artf
Copy link
Member

artf commented Jan 19, 2024

Will be available in the next release, Thanks @amirrahmani76 for the PR ❤️

@artf artf closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

8 participants