Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Droppable query selector [data-gjs-type="my-component-type"] no longer working #2010

Closed
simplecommerce opened this issue May 11, 2019 · 1 comment
Assignees
Labels

Comments

@simplecommerce
Copy link

Hi, since the latest version, I noticed that when I use the droppable query selector using [data-gjs-type="my-component-type"] no longer seems to work.

I have added two codesandbox demos to show you the issue.
I am not able to figure out what changed.

Hope it helps, thanks!

You're submitting a BUG

  1. Are you using the latest release (older versions are NOT supported)?
    Yes
  2. Are you facing the bug with your local copy of GrapesJS or with the current demo?
    Latest version available 0.14.61.
  3. What is the expected behavior?
    Components defined by type in droppable selector, would detect and allow only specified types to be dropped.
  4. What happens instead?
    Component is no longer recognized and can't be dropped into said component.
  5. If you're able to reproduce the bug indicate all the necessary steps
    1. Create two components and blocks.
    • One component has the droppable attribute selector, e.g.: droppable: ['[data-gjs-type="test-drop"]'] and the other would be the component we want to drag and drop inside the first one.
  6. Attach screenshots (using KAP/LICEcap), screencasts or live demo
    1. Version that works with the previous release - 0.14.57
    2. Version that doesn't work with the latest release - 0.14.61

To test the issue, just drag and drop the TEST block in the canvas,
and then try to drag and drop the TEST DROP block onto the TEST component.

@artf
Copy link
Member

artf commented May 12, 2019

Ok seems like the regression was introduced by this change: 702ba82#diff-6aa74cf54855daa6ca63a5d1e8b77c44R358

I'll fix it in the next release. Thanks for the report

@artf artf added this to To do in Release v0.14.62 via automation May 12, 2019
@artf artf self-assigned this May 12, 2019
@artf artf added the bug label May 12, 2019
@artf artf closed this as completed in 74300a1 Jun 3, 2019
Release v0.14.62 automation moved this from To do to Done Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants