Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Adding buttons to RTE toolbar in React App causes buttons to be duplicated. #2469

Closed
simplecommerce opened this issue Dec 24, 2019 · 2 comments · Fixed by #2471
Closed

Comments

@simplecommerce
Copy link

  1. Are you using the latest release (older versions are NOT supported)?
    • YES, 0.15.9
  2. Are you facing the bug with your local copy of GrapesJS or with the current demo?
    • Local copy
      • Are you able to reproduce the bug from the demo?
        • No, not React app.
  3. What is the expected behavior?
    • Toolbar buttons should only be added once on load of editor.
  4. What happens instead?
    • When navigating away and coming back to the editor, the toolbar buttons are duplicated, as many times as navigation is done.
  5. If you're able to reproduce the bug indicate all the necessary steps
    Attach screenshots (using KAP/LICEcap), screencasts or live demo

Result should be:

Initial look:

image

After navigation:

image

@simplecommerce
Copy link
Author

For now, I have to do rte.remove before my rte.add so it doesn't duplicate.

@artf
Copy link
Member

artf commented Dec 25, 2019

Ok, seems like we don't clear the RTE instance in the destroy method... I'll fix it for the next release

@artf artf added this to To do in Release v0.15.10 via automation Dec 25, 2019
@artf artf added the bug label Dec 25, 2019
Release v0.15.10 automation moved this from To do to Done Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants