Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: parse single nodetext as component #3034

Closed
makbari opened this issue Sep 21, 2020 · 0 comments
Closed

BUG: parse single nodetext as component #3034

makbari opened this issue Sep 21, 2020 · 0 comments

Comments

@makbari
Copy link

makbari commented Sep 21, 2020

Version: current

Are you able to reproduce the bug from the demo?

[X ] Yes
[ ] No

What is the expected behavior?
The single textnode in any component (e.g. text, cell, ...) should be parsed as a textnode component.

What is the current behavior?
Currently, a single textnode in a component is parsed as only a content in htmlParser. When, you call the components method on the child, it returns models as empty array and does not consider textnode as a component.

Are you able to attach screenshots, screencasts or a live demo?
In this demo, I some of the cells have only one text node. if you only select two cell in one row and try to merge them, since the models of the component is empty, it returns empty string.
single textnode childs should be parsed as a textnode component.
in this demo, you can try to merge last row (text1 with text2) and it fails.
Demo

@artf artf added this to To do in Release v0.16.30 via automation Dec 6, 2020
@artf artf closed this as completed in 8e7f94a Dec 6, 2020
Release v0.16.30 automation moved this from To do to Done Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant