Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot select component in component:remove handler #5633

Closed
2 tasks done
kla-ko opened this issue Jan 20, 2024 · 2 comments
Closed
2 tasks done

BUG: Cannot select component in component:remove handler #5633

kla-ko opened this issue Jan 20, 2024 · 2 comments

Comments

@kla-ko
Copy link

kla-ko commented Jan 20, 2024

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome Version 120.0.6099.225

Reproducible demo link

https://jsfiddle.net/wattnu/opmwfvjn/

Describe the bug

How to reproduce the bug?

  1. open and run the fiddle
  2. two components are on the canvas. The "hello world" div and a blue background div.
  3. The "hello world" div is selected due to the command editor.select(editor.getComponents().models[0]);
  4. When selecting the blue box and when choosing delete in the canvas spot, the component:remove handler is called.
  5. However, the "hello world" div is not selected afterwards as demanded by the instruction in the handler

What is the expected behavior?
editor.select(editor.getComponents().models[0]); shall work in the handler

What is the current behavior?
editor.select(editor.getComponents().models[0]); shows no effect in the handler

Code of Conduct

  • I agree to follow this project's Code of Conduct
@artf
Copy link
Member

artf commented Jan 21, 2024

Thanks @kla-ko there is actually one logic that prevents selecting other components during component:remove events and I will fix it for the next release but what I'd suggest to you is to switch to another event.

The event component:remove is triggered for each removed component, which means it will be triggered for each nested one inside the one you decided to remove. You can use run:core:component-delete event which is triggered only once after the deletion command is completed and it should currently work without any fix.

@kla-ko
Copy link
Author

kla-ko commented Jan 21, 2024

Thanks @artf . This works like a charme !
/

@artf artf closed this as completed in f70fd96 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants