-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.get(...).each is not a function #724
Comments
Just wondering, does
Not sure if that's what the issue is but I figured I'd chime in and try to help :) |
Hi @kickbk, It is unclear what I've not been able to recreate the error so far. I ran this code in the demo (which also currently uses version 0.12.58) after selecting a random component and it worked without errors: |
Thanks for replying guys. I traced the issue to my custom components' Traits.
As you can see my plugin extends on grapesjs-mjml. Changing default to value gives the same error. Is this the wrong way to load defaults to traits? |
Hi @kickbk and thanks for the debugging, I was able to reproduce it and fix it. |
Hi @artf glad you found the cause and fixed. It's causing your grapesjs-mjml to fail, like the demo page which doesn't load. Is this issue related to the Traits default value overriding chosen values when updating styles? See GrapesJS/mjml#50 |
Yeap, I updated the site with a temporary release, thanks |
@artf thanks for pushing a temporary release. It's still running into issues with the Social component in mjml. Steps to reproduce: add "google" to the "display" string. Click on the Styles tab, select an icon color for Facebook and watch the Google button disappear. I debugged this and for some reason when you update styles ( I spent a few hours on it and still can't pinpoint the issue. BTW "style-default" doesn't really work. Changing to "style" bring shows the default icon colors. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Getting
this.get(...).each is not a function
with the latest 0.12.58 version (cdn min.js).The line that triggers it is return
this.get("classes").each(function(e){return t.push(e.get("name"))})
The text was updated successfully, but these errors were encountered: