Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose order and visibility of Categories #742

Closed
JuanTincho opened this issue Jan 10, 2018 · 2 comments
Closed

Choose order and visibility of Categories #742

JuanTincho opened this issue Jan 10, 2018 · 2 comments
Labels

Comments

@JuanTincho
Copy link
Contributor

Hey @artf , we need to be able to change the categories order and visibility when the application starts.

I was able to do it changing the model in the Category and this piece of code in BlocksView.js:

if (category && this.categories) {
      if (typeof category.label == 'string') {
        category = {
          id: category.label,
          label: category.label,
          order: category.order,
          open: category.open,
        };
      }

...and setting the order in a flexbox property.

I wanted to know if you think this is a good approach or you have another suggestion.

I'm willing to do a PR.

Thank you!

@artf
Copy link
Member

artf commented Jan 10, 2018

I think that change in BlocksView is not necessary (at first look). If you pass the category as an object it will be added as it is with all its properties. If for a change you mean updating the view of the category with an order style (if exists) I'm ok with it

@artf artf closed this as completed in fbd2b51 Jan 13, 2018
@lock
Copy link

lock bot commented Sep 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants