Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell resizing via drag handle broken #976

Closed
TimNZ opened this issue Mar 22, 2018 · 4 comments
Closed

Cell resizing via drag handle broken #976

TimNZ opened this issue Mar 22, 2018 · 4 comments
Labels

Comments

@TimNZ
Copy link

TimNZ commented Mar 22, 2018

Bugs

Add 2 column block, select a Cell, and use resize handle to resize width.

  • Realtime width change of cell does not track the mouse pointer.
  • Dimensions fields/calculation seem broken, switching between % and px in unexpected ways.
  • Resize handle intermittently disappears

Suggest

  • Manual Cell resize needs to use a sane method to switch to px with a starting width.
  • entering auto/non-numeric into any size field clears unit
  • visual resize as expected

https://www.dropbox.com/s/avosmi1k16jgd3f/grapesjs-cell-resizing.mp4?dl=0

@artf
Copy link
Member

artf commented Mar 24, 2018

Realtime width change of cell does not track the mouse pointer

The current grid uses flexbox and as it tries to adapt itself in relation to its sibling nodes what you're asking it's not possible

Dimensions fields/calculation seem broken, switching between % and px in unexpected ways.

Not broken, there are just no calculations in unit changes

Resize handle intermittently disappears

This is something I can try to fix

@TimNZ
Copy link
Author

TimNZ commented Mar 24, 2018

Thanks for the reply. I'll have a play as well.

Awesome awesome awesome work with Grapes, greatly appreciated.

I'm using a number of components that have had a huge amount of work put in by many people and will support as soon as I can afford to.

@artf artf closed this as completed in 5bedf06 Apr 25, 2018
@TimNZ
Copy link
Author

TimNZ commented May 1, 2018

@artf legend!

@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants