Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't stop polling when migration status is still running #12

Merged
merged 2 commits into from Jul 14, 2021

Conversation

d-winter
Copy link

The SDK should not stop polling for a migration that is still in state RUNNING.

@d-winter d-winter requested a review from notrab July 14, 2021 15:57
@github-actions
Copy link

github-actions bot commented Jul 14, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.js 17.14 KB (+0.06% 🔺) 343 ms (+0.06% 🔺) 156 ms (-3.24% 🔽) 499 ms

@notrab notrab changed the title don't stop polling when migration status is still running fix: don't stop polling when migration status is still running Jul 14, 2021
Copy link
Contributor

@notrab notrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@d-winter d-winter merged commit 37f601c into main Jul 14, 2021
@d-winter d-winter deleted the dwinter/fix-migrationstatus branch July 14, 2021 21:27
@github-actions
Copy link

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants