Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught errors can not be easily logged #4

Open
chrisportela opened this issue Dec 23, 2015 · 2 comments
Open

Uncaught errors can not be easily logged #4

chrisportela opened this issue Dec 23, 2015 · 2 comments

Comments

@chrisportela
Copy link

Either using django's logger or through some hook there needs to be a way that things like sentry can know about these uncaught exceptions.

Issue is primarily in graphql_django_view/__init__.py in dispatch() of GraphQLView

except HttpError as e:
            response = e.response
            response['Content-Type'] = 'application/json'
            response.content = self.json_encode(request, {
                'errors': [self.format_error(e)]
            })
            return response
@jhgg
Copy link
Collaborator

jhgg commented Dec 23, 2015

Working on this in graphql-core.

graphql-python/graphql-core#41

Planning to have that done by new years.

On Dec 23, 2015, at 8:30 AM, Chris Portela notifications@github.com wrote:

Either using django's logger or through some hook there needs to be a way that things like sentry can know about these uncaught exceptions.

Issue is primarily in graphql_django_view/init.py in dispatch() of GraphQLView

except HttpError as e:
response = e.response
response['Content-Type'] = 'application/json'
response.content = self.json_encode(request, {
'errors': [self.format_error(e)]
})
return response

Reply to this email directly or view it on GitHub.

@rattrayalex
Copy link

In graphql-python/graphql-core#41 (comment) @syrusakbary claims this was fixed. Should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants