Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review existing GUI language parsing/AST/component generation code and architecture #28

Closed
Keavon opened this issue Feb 14, 2021 · 1 comment
Labels
Help Wanted Extra attention is needed

Comments

@Keavon
Copy link
Member

Keavon commented Feb 14, 2021

I'd love to sit down and talk through the codebase and find what should be redesigned or refactored before proceeding with building the DOM tree (#4). Having a second opinion on the usage of terminology throughout the code would be excellent as well. See this documentation for a primer on the GUI system. There's also a more detailed specification in a Google Doc that I need to convert to a Markdown file and add to the repo.

This code review pertains to the following files:

  • gui_attributes.rs
  • gui_node.rs
  • layout_abstract_syntax.rs
  • layout_abstract_types.rs
  • layout_attribute_parser.rs
  • layout_system.rs
  • window_dom.rs
  • window_events.rs

Entry point in application.rs:

let mut main_window_layout = LayoutSystem::new();
main_window_layout.add_window(("window", "main"));
@Keavon Keavon added Code Review Help Wanted Extra attention is needed labels Feb 14, 2021
@Keavon
Copy link
Member Author

Keavon commented Feb 15, 2021

Shelved on account of switching to a web app frontend for the short term.

@Keavon Keavon closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant