Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties panel doesn't go blank after clicking in Layer Tree panel to deselect, requires a second click to blank it #597

Closed
bjorn3 opened this issue Apr 21, 2022 · 10 comments · Fixed by #606
Closed

Properties panel doesn't go blank after clicking in Layer Tree panel to deselect, requires a second click to blank it #597

bjorn3 opened this issue Apr 21, 2022 · 10 comments · Fixed by #606
Assignees
@0HyperCube
Labels
Bug Something isn't working Rust Involves Rust programming for the backend
Milestone
Sprint 14

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Apr 21, 2022 •
edited by Keavon

The first click in the empty area of the Layer Tree deselects the layers but the Properties panel doesn't go blank. It takes a second click in the same place to make it go blank.

Peek.2022-04-21.18-55.mp4
@bjorn3 bjorn3 added the Bug Something isn't working label Apr 21, 2022
@Keavon
Copy link
Member

Keavon commented Apr 21, 2022

Clicking blank space in the Layer Tree panel should deselect the selection. However it's a bug that it requires clicking again to make the Properties panel go blank.

@0HyperCube
Copy link
Member

It appears that you can draw things (i.e. using the rectangle tool) by dragging the empty space in one of the panels.

@Keavon
Copy link
Member

Keavon commented Apr 21, 2022

It appears that you can draw things (i.e. using the rectangle tool) by dragging the empty space in one of the panels.

Oh you're right, that's really weird.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Apr 21, 2022

It doesn't just happen in the layer tree panel. It also happened in the property pane for me a couple of times. Can't really reproduce though.

@Keavon
Copy link
Member

Keavon commented Apr 21, 2022

It looks like dragging the gutter between panels to resize them also causes a deselection. And when you click and drag (but not just click) in blank space in the properties panel. This might be due to the tools interacting with the out-of-the-viewport areas and it's just acting like it is doing a blank selection with the Select Tool.

@Keavon
Copy link
Member

Keavon commented Apr 21, 2022

Indeed, even dragging in the footer or title bar also causes it to operate the tool. So presumably that's the real bug. (Besides possibly the second bug that may or may not be related where deselecting in the Layer Tree takes two clicks to blank the Properties panel.)

@0HyperCube
Copy link
Member

Indeed (with rectangle tool)
gutter

@Keavon
Copy link
Member

Keavon commented Apr 21, 2022 •
edited

@0HyperCube the bug where you can click and drag to use tools outside the viewport was introduced in #589. My best guess is this may be from the changes to the input preprocessor which dealt with multiple button clicks on mousemove.

Edit: that bug has been fixed in #600

@Keavon Keavon changed the title Clicking on empty space in the layer tree pane deselects the current element Clicking and dragging outside the viewport is treated as tool interaction Apr 21, 2022
@0HyperCube 0HyperCube mentioned this issue Apr 21, 2022
Merged
@Keavon Keavon changed the title Clicking and dragging outside the viewport is treated as tool interaction Properties panel doesn't go blank after clicking in Layer Tree panel to deselect, requires a second click to blank it Apr 21, 2022
@Keavon Keavon added Available Rust Involves Rust programming for the backend labels Apr 21, 2022
@Keavon Keavon added this to the Sprint 14 (ongoing) milestone Apr 21, 2022
@0HyperCube
Copy link
Member

The clicking to deselect layers was intentional, other behaviour has been resolved by #600.

@0HyperCube
Copy link
Member

Sorry the double click to clear the layer panel has not been resolved.

@0HyperCube 0HyperCube reopened this Apr 21, 2022
@0HyperCube 0HyperCube mentioned this issue Apr 22, 2022
Merged
@Keavon Keavon removed the Available label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0HyperCube 0HyperCube

Labels
Bug Something isn't working Rust Involves Rust programming for the backend
Projects
Task Board
Archived in project
Milestone
Sprint 14
Development

Successfully merging a pull request may close this issue.

Fix properties deselect GraphiteEditor/Graphite
3 participants
@Keavon @bjorn3 @0HyperCube