[Bug][Solved] Sinobu's skill is abnormal

[einekuhmachtmuh]

So far, I haven't seen similar issue, but have asked for support in Discord.

Main Problem:
At the moment of Shinobu's E casting, she heals the avatar twice, then no more healing.

Grasscutter Edition:
version: 1.4.3-Release
Git Hash: 5c4c62c

Extra Info:
Damage of Shinobu's Q isn't in scale with her Life.

[NotThorny]

Self-damage was never been implemented so it's not a bug that it isn't working. Healing abilities are also a bit patchwork in how they are implemented, they were not really 'implemented correctly'. Healing is defined manually per-character in HealAbilityManager, specifically Shinobu's abilities are defined here :
https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/game/ability/HealAbilityManager.java#L102

You can then refer here to where ability modifiers are read from BinOutput in resources :
https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/data/ResourceLoader.java#L292

Then how that ability is handled by AbilityManager :
https://github.com/Grasscutters/Grasscutter/blob/development/src/main/java/emu/grasscutter/game/ability/AbilityManager.java#L153

This isn't really a 'bug' as much as it is just not implemented. Healing being implemented 'correctly' would be the way to fix this and all other healing abilities.

[einekuhmachtmuh]

OK, I'll solve it on my own coding.

[NotThorny]

Should be fixed in the most recent release of Grasscutter, actually. Abilities should be at least generally working correctly, including self-damage.

[einekuhmachtmuh]

I have tested Shinobu, and her heal is properly fixed (in #2166). However, in 1.6.1 skill can't generate balls

2023-06-03.13-11-54.mp4

This problem should be fixed after #2066.
The code of energy manger and generated proto seems to be the same as the previous "work" edition. I haven't checked the packets (packets plugin can't be loaded), so I'm not sure the cause.

[KingRainbow44]

its the new ability system, which doesnt have elemental energy balls implemented

[einekuhmachtmuh]

Generation of elemental balls has implemented in b09c0d4 commit.