Abort request on missing Graylog server version #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fail to read the server version from Graylog, stop using a fallback to 4.0.0 and retry the request instead. In scenarios with multiple Graylog nodes behind a load balancer, this can lead to the sidecar temporarly stopping all collectors. Fixes #481
thll
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
LGTM
One thing I noticed is that if the load balancer returns an error without a JSON body, the sidecar will log errors like this:
ERRO[0081] Error fetching server version invalid character '<' looking for beginning of value
ERRO[0081] [UpdateRegistration] Bad response from Graylog server: 503 Service Temporarily Unavailable
This is for the following response:
curl -v localhost:80/api/
* Trying 127.0.0.1:80...
* Connected to localhost (127.0.0.1) port 80 (#0)
> GET /api/ HTTP/1.1
> Host: localhost
> User-Agent: curl/8.1.2
> Accept: */*
>
< HTTP/1.1 503 Service Temporarily Unavailable
< Server: nginx
< Date: Fri, 13 Oct 2023 13:04:03 GMT
< Content-Type: text/html
< Content-Length: 190
< Connection: keep-alive
<
<html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body>
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>nginx</center>
</body>
</html>
* Connection #0 to host localhost left intact
That is something we could improve but we don't have to do it in this PR.
thll
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to read the server version from Graylog, stop using a fallback to 4.0.0 and retry the request instead.
In scenarios with multiple Graylog nodes behind a load balancer, this can lead to the sidecar temporarly stopping all collectors.
Fixes #481
Notes for Reviewers