Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for termination of netty on Transport.stop() #12

Closed
camann9 opened this issue Feb 27, 2015 · 1 comment
Closed

Wait for termination of netty on Transport.stop() #12

camann9 opened this issue Feb 27, 2015 · 1 comment
Labels
enhancement

Comments

@camann9
Copy link

camann9 commented Feb 27, 2015

Currently the AbstractGelfTransport.stop() method doesn't wait for the returned future to terminate before returning. It would be desirable to block during netty termination or to offer another stop method that is blocking (or to return the future). Example for blocking shutdown:

workerGroup.shutdownGracefully()..awaitUninterruptibly()
@bernd
Copy link
Member

bernd commented Jun 19, 2015

Thanks for the heads up!

@bernd bernd closed this as completed in 15bc519 Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernd @camann9