Client attempts to reconnect during shutdown

[danotorrey]

When shutting down the GELF Client, it immediately attempts to reconnect, which results in the following error message:

INFO org.graylog2.gelfclient.transport.GelfHttpTransport - Channel disconnected!

The same issue happens for the transport.stop() and transport.flushAndStopSynchronously() methods.

No ill effects occur, but this should be cleaned up. Reconnects should not be attempted after calling either of the stop methods.

[lingpri]

I was reading through the class GelfHttpTransport.java, lineno:113 and am wondering , if method exceptionCaught is missing ctx.close() in it.

@Override public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { LOG.error("Exception caught", cause); }

[lingpri]

Stack Overflow Ref link:

Development Environment Setup for debugging

JUST an FYI, to enable debugging pass this as a vm argument in INtellij
-Dorg.slf4j.simpleLogger.defaultLogLevel=debug

[gelfHttpTransport-1-1] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded inbound message DefaultHttpResponse(decodeResult: success, version: HTTP/1.1) HTTP/1.1 202 Accepted content-length: 0 connection: close that reached at the tail of the pipeline. Please check your pipeline configuration. [gelfHttpTransport-1-1] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded message pipeline : [HttpClientCodec#0, HttpContentDecompressor#0, GelfHttpEncoder#0, GelfMessageJsonEncoder#0, GelfHttpTransport$1$1#0, DefaultChannelPipeline$TailContext#0]. Channel : [id: 0x43372ef6, L:/127.0.0.1:51548 - R:/127.0.0.1:42323]. [gelfHttpTransport-1-1] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded inbound message EmptyLastHttpContent that reached at the tail of the pipeline. Please check your pipeline configuration. [gelfHttpTransport-1-1] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded message pipeline : [HttpClientCodec#0, HttpContentDecompressor#0, GelfHttpEncoder#0, GelfMessageJsonEncoder#0, GelfHttpTransport$1$1#0, DefaultChannelPipeline$TailContext#0]. Channel : [id: 0x43372ef6, L:/127.0.0.1:51548 - R:/127.0.0.1:42323]. [gelfHttpTransport-1-1] INFO org.graylog2.gelfclient.transport.GelfHttpTransport - Channel disconnected! [GelfSenderThread-14] DEBUG org.graylog2.gelfclient.transport.GelfSenderThread - GelfSenderThread exiting!

[lingpri]

@danotorrey In class , GelfHttpEncoder, making the HTTP header connection, to keep alive, request.headers().set(HttpHeaderNames.CONNECTION, HttpHeaderValues.KEEP_ALIVE);
doesn't call the lifecycle method
public void channelInactive(ChannelHandlerContext ctx) throws Exception

I'm thinking this is not a bug. Please advice.