New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linefeed character #2
Comments
I'm guessing you are referring to the README quickstart example. Thanks for the heads up - fixed in e97f37b
Yes I need to work on that, as the comment in the code suggests, the situation where multiple rows are added at once is not handled yet, same with multiple columns and multiple column names being changed. If you add one row at a time it should work. But that is on the TODO list. I just need to decide if, when several rows are added, I want to raise multiple "RowAppended" events or a single "RowsAppended" event. Not sure? Thanks for testing my library! |
I think enough a simple event when added a row, no matter one or more. Further, if we delete all rows through the context menu, and then the next time a value is added, the row_appended/row_inserted event does not fired. I think this is because ListObject.DataBoundRange is Nothing when has none of values in it. Further, if we resize the border of the listobject (I think you know such a small triangle at the bottom right of the ListObject) , we also do not receive any event. Now, I am also currently using subclassing over shapes, maybe it will be helpful also in your project? See it here https://gist.github.com/sancarn/246c0bbe2c8ec35cb492865a9843e3c6 Thank you for sharing your fine project. |
@sergeos Resize, Move, and maybe OnSort/Filter are all on my todo list (Resize and Move I know can be done as I've drafted them previously). Thanks for the link although that uses quite a different technique for shapes to tables they're not really comparable.
Can you clarify I'm not sure what you mean. I was not aware you could remove every single row of a table leaving only the headers? If a single row is left this code should handle that edge case. PS Can I check with you I have a new release https://github.com/Greedquest/ListObject-WithEvents/releases/tag/v0.1.0-alpha which includes a demo workbook can you recreate the issue in that? On the sheet called "ScratchSheet". I just put a table with randomly generated data for testing |
Apologies I never got back to you. For that you need to add a reference to Rubberduck in Tools/References. Do you use that? If not then you can delete any of the code in modules that doesn't compile, they are just the testing modules and I should probably exclude them |
Repo uses LF not CRLF meaning .bas .cls files cannot be imported by VBE or RD. Need to use .gitattributes file to fix treatment.
Workaround execute the following two in powershell in the src directory of this repo to fix the newlines:
And in the src directory
The text was updated successfully, but these errors were encountered: