Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish nuget package to consume #40

Closed
luwangshell opened this issue Jan 28, 2022 · 9 comments
Closed

Publish nuget package to consume #40

luwangshell opened this issue Jan 28, 2022 · 9 comments
Assignees

Comments

@luwangshell
Copy link

It will be easier for other libs or application to consume or implement the sdk by referencing with published nuget package.

@luwangshell
Copy link
Author

@vaughanknight I would like to work on this one. Could you advise how to proceed? It seems I cannot assign this one to myself. thank you.

@tw-kishan-vaishnav
Copy link

I would like to help in this ticket. This is the first time I will be contributing. So, can you please explain what needs to be done and how.

@luwangshell
Copy link
Author

luwangshell commented Feb 16, 2022

Sure! @tw-kishan-vaishnav Thank you! The intent is once a nuget package is published, then the consumers (apps or libs) can reference carbon-aware-sdk as a dependencies as a nuget package to use or implement the interfaces defined in the sdk.

@tw-kishan-vaishnav
Copy link

Can we use the nuget.org repository? I am new to docker container. So, not sure how to build them.

@luwangshell
Copy link
Author

I am fine either way, as long as it can be consumed easily. @vaughanknight thoughts?

@tw-kishan-vaishnav
Copy link

I think below Class Libraries need to be published:

  • CarbonAware

  • CarbonAware.Plugins.BasicJsonPlugin

I have created .nupkg files for both the projects with version 1.0.0.

Please provide apiKey to publish them to a repository.

Thanks @tw-arun-ap for support.

@luwangshell
Copy link
Author

luwangshell commented Mar 9, 2022

@tw-kishan-vaishnav thanks! could you publish to the GitHub package?

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-nuget-registry

from the instruction above, you can use your github PAT to publish the package.

dotnet nuget push "bin/Release/OctocatApp.1.0.0.nupkg" --api-key YOUR_GITHUB_PAT --source "github"

@yelghali
Copy link
Contributor

yelghali commented Mar 13, 2022

hello @tw-kishan-vaishnav, I have started building DevOps/DevSecops pipelines for the SDK (CLI as Docker Image & Github Action ; API as Docker image, Doc website, code security scanning, etc.)

I'll be happy to collaborate with you to build the dotnet package (in CICD Github Action), and publish it as @luwangshell suggested.

lopping @vaughanknight, I propose to take higher level conversation on the artifacts to be published for the SDK (for instance dotnet package or Docker Image):

Started in the link below, an initial proposal (to be discussed / enhanced)
#46

thank you
Yassine

@vaughanknight
Copy link
Contributor

Closing this one out as after much deliberation we do not want to automatically publish nuget packages (for now). Primarily this is because it will require long term agreement to manage and support. This may come back at some point but right now it's not a priority. This is also because client generation will be included, and as such teams may manage their own packages within a large company (and would not be using public packages anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants