Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable grpc compression #1445

Closed
MichaelScofield opened this issue Apr 24, 2023 · 3 comments · Fixed by #3403
Closed

Enable grpc compression #1445

MichaelScofield opened this issue Apr 24, 2023 · 3 comments · Fixed by #3403
Labels
C-feature Category Features

Comments

@MichaelScofield
Copy link
Collaborator

What problem does the new feature solve?

Reduce bandwidth while dealing with grpc requests and responses.

What does the feature do?

There are two places we can enable compression:

We can enable both.

Implementation challenges

No response
@MichaelScofield MichaelScofield added the C-feature Category Features label Apr 24, 2023
@e1ijah1
Copy link
Contributor

e1ijah1 commented May 5, 2023

I'm quite interested in this feature and would like to contribute if possible. Could you please confirm if the compression for Arrow Flight is implemented within the FlightEncoder struct? I would greatly appreciate any further details regarding the implementation.

@MichaelScofield
Copy link
Collaborator Author

@e1ijah1 welcome! Yes, compression for Arrow data is set in IpcWriteOptions, which is owned by the FlightEncoder. You may find this usefull: https://stackoverflow.com/questions/71802355/possible-ways-to-compress-apache-arrow-recordbatch

@MichaelScofield MichaelScofield added the A-frontend Involves code in the Frontend node label Jun 7, 2023
@tisonkun tisonkun mentioned this issue Feb 28, 2024
Merged
3 tasks
@tisonkun tisonkun removed the A-frontend Involves code in the Frontend node label Feb 28, 2024
@tisonkun
Copy link
Contributor

How can it be relevant to "Frontend"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable ArrowFlight compression tisonkun/greptimedb
3 participants
@MichaelScofield @tisonkun @e1ijah1