Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export tokio runtime metrics from tokio-console #1529

Closed
MichaelScofield opened this issue May 6, 2023 · 2 comments · Fixed by #2985
Closed

Export tokio runtime metrics from tokio-console #1529

MichaelScofield opened this issue May 6, 2023 · 2 comments · Fixed by #2985
Assignees
Labels
Help wanted Extra attention is needed

Comments

@MichaelScofield
Copy link
Collaborator

MichaelScofield commented May 6, 2023

@waynexia didn't find any metrics related things in its docs, can you give a hint?

I'm looking at this document, but I haven't tried it myself. The path is not that straightforward:

  • collect data from tokio-console via tracing library (by adding a console layer)
  • export data from tracing to metrics subscriber (we haven't do this yet)

And it looks that the metrics (or maybe traces) are not configurable. We probably want to do more experenments on it before put it into our codebase. Thus it's better to do this in another PR.

Originally posted by @waynexia in #1512 (comment)

As the comment above suggests, we may export the metrics of tokio runtime by digging into tokio-console(tokio's console-subscriber), or using its console-api.

@waynexia waynexia added Help wanted Extra attention is needed Size: M labels May 6, 2023
@waynexia waynexia modified the milestone: v0.3 May 8, 2023
@SSebo
Copy link
Contributor

SSebo commented Oct 18, 2023

Is this issue only for new contributor? Or any one interested can involve in?

@MichaelScofield
Copy link
Collaborator Author

@SSebo you are very welcome to take this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants