Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mem-prof feature by default #3166

Open
v0y4g3r opened this issue Jan 15, 2024 · 1 comment
Open

Enable mem-prof feature by default #3166

v0y4g3r opened this issue Jan 15, 2024 · 1 comment
Labels
Enhancement New feature or request Feature request Request a feature

Comments

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Jan 15, 2024

What type of enhancement is this?

Configuration, User experience

What does the enhancement do?

mem-prof feature is disabled by default. When users encounter memory related issues, a recompilation is requried to do memory analysis. We may set mem-prof as default feature so that users only need to export MALLOC_CONF=prof:true and restart GreptimeDB instance.

Implementation challenges

Not much work to implement this, but I wonder if there's any security concern. Did a simple research but I didn't find any CVE related to jemalloc's profiling feature.

@v0y4g3r v0y4g3r added Enhancement New feature or request Feature request Request a feature labels Jan 15, 2024
@evenyag
Copy link
Contributor

evenyag commented Jan 15, 2024

Will it be a problem when we want to disable jemalloc? We should provide a way to disable jemalloc if we enable the mem-prof handler by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Feature request Request a feature
Projects
None yet
Development

No branches or pull requests

2 participants