Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timestamp epoch integer in to_timezone function #3477

Closed
tisonkun opened this issue Mar 11, 2024 · 1 comment · Fixed by #3620
Closed

Support timestamp epoch integer in to_timezone function #3477

tisonkun opened this issue Mar 11, 2024 · 1 comment · Fixed by #3620
Assignees
@etolbakov
Labels
Good first issue Good for newcomers

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Mar 11, 2024 •
edited

What type of enhancement is this?

API improvement

What does the enhancement do?

From #3470 and follow up #2029.

We support timestamp type only so far (String can be implicitly casted to timestamp). Perhaps add support for timestamp epoch integer in milliseconds precison.

Implementation challenges

No response
@v0y4g3r v0y4g3r added the Good first issue Good for newcomers label Mar 27, 2024
@tisonkun
Copy link
Contributor Author

You can check the code here for how to handle Int input.

@etolbakov etolbakov self-assigned this Mar 29, 2024
@etolbakov etolbakov mentioned this issue Mar 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etolbakov etolbakov

Labels
Good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(function): add timestamp epoch integer support for to_timezone etolbakov/greptimedb
3 participants
@etolbakov @v0y4g3r @tisonkun