Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim ID Issue #139

Closed
Dreamthief01 opened this issue Jun 3, 2017 · 6 comments
Closed

Claim ID Issue #139

Dreamthief01 opened this issue Jun 3, 2017 · 6 comments

Comments

@Dreamthief01
Copy link

There seems to be a maximum claim ID of 9999 and after that the claim id tracker file appears to reset to zero and start over. This is causing my oldest claims to have their associated claim ID file overwritten by a new player creating a new claim which then takes that same ID number.

My server is about 2 years old and all of my player's oldest spawns are now becoming unclaimed by new players creating new claims.

Can we remove this cap or change it over to an integer or something else large enough to never be capped. Please let me know if i missed a config file setting somewhere that governs this.

No real stack trace or error per say on this issue.

Thanks,

Dreamthief01,
TerminalServer.us

@zedwick
Copy link

zedwick commented Jun 3, 2017

Are you sure it's 9999? I have claims with IDs beyond 16000

@Jikoo
Copy link
Collaborator

Jikoo commented Jun 3, 2017

Could be a duplicate of #120 - my current nextClaimID is 20562993, it's certainly not capped to 9999. Consider shutting down the server and manually fixing GriefPreventionData/ClaimData/_nextClaimID.

@Dreamthief01
Copy link
Author

Ah, my mistake, I see now that I do have ids in the 11,000s but the way my list was sorted 9999 was the highest i was seeing. Looks like something reset my file. Ill manually adjust it. Thanks!

@Dreamthief01
Copy link
Author

Although I was wrong about this issue, this still seems like an odd way to code this. Doesn't the system need to read in all of the files on load anyhow and cant it just figure out what the next number should be based on the highest one it read in? Then just use and increment that tracker in memory until next server startup. What was the benefit of storing that tracker counter in a separate file I wonder.

@RoboMWM
Copy link

RoboMWM commented Jun 3, 2017

Doesn't the system need to read in all of the files on load anyhow and cant it just figure out what the next number should be based on the highest one it read in? Then just use and increment that tracker in memory until next server startup. What was the benefit of storing that tracker counter in a separate file I wonder.

Perhaps some people move/freeze/other backup claim files, and then want to move them back in? Also, if anything uses the API for claim IDs, it'd be better that each unique claim has a unique ID. That being said, will likely implement this idea to "recover" a broken _nextClaimID file

Looks like something reset my file. Ill manually adjust it.

Likely due to a full hard drive, or other I/O corruption.

@RoboMWM
Copy link

RoboMWM commented Sep 4, 2018

Also referenced in #207, closed with commit e17403f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants