Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect dropped items in worlds where claiming is disabled #1995

Open
1 of 9 tasks
Tosfoy opened this issue Jan 12, 2023 · 5 comments
Open
1 of 9 tasks

Protect dropped items in worlds where claiming is disabled #1995

Tosfoy opened this issue Jan 12, 2023 · 5 comments
Milestone

Comments

@Tosfoy
Copy link

Tosfoy commented Jan 12, 2023

Observed Behavior

Drops of players are not being protected in the end nor nether.
We only allow claiming in the overworld.
End and Nether are Disabled

Expected Behavior

They should be protected on death no matter if the world is disabled or not.
We don't want players to claim in the end or nether but we do want their stuff to be protected on death

Reproduction steps

Disable Nether and End claim
Die and have someone walk over your loot

Stack trace or error log

No response

Server version

1.19.3, Pufferfish-54

GriefPrevention version

Latest GP version

Configuration

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/

GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
    spawn: -1
  Claims:
    Mode:
      world_the_end: Disabled
      spawn: Disabled
      world_nether: Disabled
      world: Survival
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: false
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 100
    Claim Blocks Accrued Per Hour:
      Default: 75
    Max Accrued Claim Blocks:
      Default: 10000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 64
    MinimumWidth: 5
    MinimumArea: 100
    MaximumDepth: -2147483648
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 7
      UnusedClaimDays: 14
      AllClaims:
        DaysInactive: 60
        ExceptWhenOwnerHasTotalClaimBlocks: 2147483647
        ExceptWhenOwnerHasBonusClaimBlocks: 2147483647
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: false
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: true
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: false
      world_nether: false
      world_the_end: true
      spawn: false
    ProtectFreshSpawns: true
    PunishLogout: true
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: true
    BlockedSlashCommands: /home;/spawn;/tpa;/feed;/heal;/tpaccept;/crates;/market;/dropparty;/pwarp;/warp;/warps;/mine;/dungeon
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: true
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 8.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: true
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  PistonMovement: CLAIMS_ONLY
  PistonExplosionSound: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  VisualizationAntiCheatCompatMode: false
  SmartBan: true
  Mute New Players Using Banned Words: false
  MaxPlayersPerIpAddress: 3
  SilenceBans: true
  Siege:
    Worlds: []
    BreakableBlocks:
    - GRASS_BLOCK
    - DIRT
    - COBBLESTONE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - SAND
    - GRAVEL
    - GLASS
    - GRASS
    - FERN
    - DEAD_BUSH
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    - GLASS_PANE
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false

Plugin list

No response

Running without GriefPrevention

  • I attempted running the server without GriefPrevention installed.
  • The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

  • I attempted running only GriefPrevention on the server.
  • The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

  • I attempted testing for the issue on a new server.
  • The issue still occurs on a new server.

Using unmodified client

  • I attempted testing for the issue with the vanilla client.
  • The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

  • I searched for similar issues before submitting this bug report.
@RoboMWM RoboMWM added the Need more info More information is needed to determine what's going on. label Mar 12, 2023
@Tosfoy
Copy link
Author

Tosfoy commented Jan 19, 2024

Unsure how to give more information on this and it has been a year but:
We want to protect items dropped on death in all worlds, without enabling claims in nether/end

@RoboMWM
Copy link

RoboMWM commented Jan 19, 2024

Need actual version, as at least 2 beta releases have been released along with various fixes to drops protections and paper changes.

@Tosfoy
Copy link
Author

Tosfoy commented Jan 19, 2024

Version: 16.18.2-beta2 (Latest)
Pufferfish+ 1.20.1

We want players to be able to have their items protected on death in all worlds, even worlds which the claims are disabled
I am talking about the item protecting, which players are able to do /unlockdrops

Observed Behavior
Items are only protected in world where the claim config is set to enabled (survival)
Player dying in the End & Nether will not have their stuff protected since the claims are disabled here and other players are able to pickup items on the ground.

Expected Behavior
Claims should not relate to "ProtectItemsDroppedOnDeath"
If items protected on death is enabled, it should apply to all worlds.

Important lines in the config related to the issue
Claims:
Mode:
world_nether: Disabled
world_the_end: Disabled
world: Survival
ProtectItemsDroppedOnDeath:
PvPWorlds: true
NonPvPWorlds: true

@Jikoo
Copy link
Collaborator

Jikoo commented Jan 19, 2024

As an interim solution, you should be able to enable claims in those worlds but remove players' permission to claim.

@RoboMWM RoboMWM changed the title Protect items dropped on death not working in the End nor Nether Protect dropped items in worlds where claiming is disabled Jan 19, 2024
@RoboMWM RoboMWM added Enhancement and removed Need more info More information is needed to determine what's going on. labels Jan 19, 2024
@RoboMWM RoboMWM added this to the 18.0.0 milestone Jan 19, 2024
@RoboMWM
Copy link

RoboMWM commented Jan 19, 2024

As a server administrator,
I want my players' death drops to be protected in worlds where claims are disabled,
Because I want my players' death drops to be protected everywhere on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants