Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowerpot griefing #386

Closed
x1p opened this issue Oct 1, 2018 · 11 comments
Closed

Flowerpot griefing #386

x1p opened this issue Oct 1, 2018 · 11 comments
Labels
🐛Bug Issue is a validated bug report. 🚫Invalid Issue not applicable or insufficient information provided/template not filled out.

Comments

@x1p
Copy link

x1p commented Oct 1, 2018

It is possible to steal flowers out of the pot inside claims.

Griefprevention 16.11.3
WorldGuard v7.0.0-SNAPSHOT;1749-a6261b9

@x1p
Copy link
Author

x1p commented Oct 1, 2018

Exists too in GP 16.11.4

@RoboMWM
Copy link

RoboMWM commented Oct 1, 2018

This is a client glitch as I'm sure I already fixed this a while ago. If you relog into the server you'll find that the flower pot hasn't been griefed.

Unless of course spigot 1.13 changed that stuff, which they may have. So I'm going to need all the ticket info that you deleted.

@RoboMWM RoboMWM added the 🚫Invalid Issue not applicable or insufficient information provided/template not filled out. label Oct 1, 2018
@x1p
Copy link
Author

x1p commented Oct 1, 2018

No it's not a client glitch. The item is indeed in the inventory and is droppable.

@x1p
Copy link
Author

x1p commented Oct 1, 2018

@mirolm
Copy link

mirolm commented Oct 1, 2018

It is indeed possible to do that. I just tried it on my server with latest GP.

@RoboMWM Note that it is impossible to break the pot, but possible to pickup the sappling / flower from the pot. You cannot return it back tho, because it says you need administrator / claim owner rights.

It does not prevent you to get the item from the pot, but blocks you from returning it back. Maybe a check on pickup from pot is missing.

This server is running CraftBukkit version git-Spigot-f6a273b-7a2f486 (MC: 1.13.1)
[GriefPrevention] Loading GriefPrevention v16.11.4.dev

@x1p
Copy link
Author

x1p commented Oct 1, 2018

thank you for confirming

@RoboMWM
Copy link

RoboMWM commented Oct 1, 2018

Ok, thank you mirolm for providing reproduction and details. x1p you can't just delete the issue template, it exists for a reason.

@RoboMWM RoboMWM added the 🐛Bug Issue is a validated bug report. label Oct 1, 2018
@112RG
Copy link

112RG commented Nov 2, 2018

The bug seems to be happening because when right-clicking the flower in the pot, the material isn't FLOWER_POT. The material is now POTTED_{wood type}_SAPPLING

@RoboMWM
Copy link

RoboMWM commented Nov 2, 2018

Thanks. I'm guessing a Tag could be used here? Or better yet an event (but I doubt there is such)?

@112RG
Copy link

112RG commented Nov 2, 2018

I have a PR adding all the materials. Is there a better way todo it than that?

@112RG 112RG mentioned this issue Nov 2, 2018
@RoboMWM
Copy link

RoboMWM commented Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Issue is a validated bug report. 🚫Invalid Issue not applicable or insufficient information provided/template not filled out.
Projects
None yet
Development

No branches or pull requests

4 participants