Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping corners #997

Closed
digimbyte opened this issue Sep 5, 2020 · 6 comments · Fixed by #1148
Closed

Overlapping corners #997

digimbyte opened this issue Sep 5, 2020 · 6 comments · Fixed by #1148
Labels
🐛Bug Issue is a validated bug report.

Comments

@digimbyte
Copy link

digimbyte commented Sep 5, 2020

What happened:

corners overlapping, can't move one node when clicking the corner. intead it moves all corners together

What was expected:

expected to move the most appropriate corner to make the claim larger

Steps to reproduce:

set tool to feather
have to many blocks claimed and try and create an admin claim of a small area, use command to adjust claim points

Server and GriefPrevention version:

This can be found by running /version and /version GriefPrevention on your server.
Paste of /version: git_Paper-161 (MC: 1.16.2) ( API version 1.16.2-R0.1-SNAPSHOT)
Paste of /version GriefPrevention: 16.14.0

Stack trace/error or server log

No server errors

GriefPrevention config.yml

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/
GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
    world_the_end: -1
  Claims:
    Mode:
      world_nether: Disabled
      world: Survival
      world_the_end: Disabled
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: false
    LockTrapDoors: false
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 100
    Claim Blocks Accrued Per Hour:
      Default: 100
    Max Accrued Claim Blocks:
      Default: 2000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    ExtendIntoGroundDistance: 5
    MinimumWidth: 5
    MinimumArea: 100
    MaximumDepth: 0
    InvestigationTool: STICK
    ModificationTool: FEATHER
    Expiration:
      ChestClaimDays: 7
      UnusedClaimDays: 14
      AllClaims:
        DaysInactive: 60
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: true
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: true
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: true
      world_nether: true
      world_the_end: true
    ProtectFreshSpawns: true
    PunishLogout: true
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: false
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: true
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  CheckPistonMovement: true
  LimitPistonsToLandClaims: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 3
  Siege:
    Worlds: []
    BreakableBlocks:
    - DIRT
    - GRASS_BLOCK
    - GRASS
    - FERN
    - DEAD_BUSH
    - COBBLESTONE
    - GRAVEL
    - SAND
    - GLASS
    - GLASS_PANE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false

Plugin list (if applicable):

EssentialsX
GP Flags
Farm Limiter
Jobs
Lucky Permissions
mcMMO
VoxelSniper
WorldEdit

Debugging steps attempted

tried moving corners, giving the claim, abandoning claim

image
image

@digimbyte
Copy link
Author

might be related to a double fire issue I've experienced with voxelSniper as well.

@RoboMWM
Copy link

RoboMWM commented Sep 7, 2020

Ya, it's a spigot bug with PlayerInteractEvent from what someone else reported on the spigot thread. Try updating Paper, I think the bug was resolved in the spigot issue tracker but idk how or what.

@Jikoo
Copy link
Collaborator

Jikoo commented Dec 10, 2020

OP was very confusingly worded, description and reproduction steps are very unclear. The bug is actually that when resizing a claim along an axis with a length of 1, the claim is moved instead of resized.

To replicate:

  1. Create a claim with a width of 1
    • Must be an admin claim or subclaim using default config
  2. Attempt to resize claim using golden shovel
    • Command functions as expected, cannot use command to replicate
  3. Observe that claim has changed location instead of resizing

Claim will resize along any axis that is not a length of 1.

image
image

@RoboMWM
Copy link

RoboMWM commented Dec 10, 2020

hmm, what about 1x1 claims then, does it just move the 1x1 claim

@Jikoo
Copy link
Collaborator

Jikoo commented Dec 10, 2020

1x1 claims move from point a to point b, yes.

@RoboMWM
Copy link

RoboMWM commented Dec 10, 2020

Nice.

I guess this is something we can look into at some point, but definitely ultra low priority as this can easily be remedied via abandoning and creating a new claim.

@RoboMWM RoboMWM added 🐛Bug Issue is a validated bug report. and removed Unverified Bug labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Issue is a validated bug report.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants