Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Get java installpath automatically #5

Closed
Griefed opened this issue Feb 28, 2021 · 1 comment
Closed

[Feature] Get java installpath automatically #5

Griefed opened this issue Feb 28, 2021 · 1 comment
Assignees
Labels
accepted Feature Ask which got accepted. bug Something isn't working enhancement New feature, request or improvement

Comments

@Griefed
Copy link
Owner

Griefed commented Feb 28, 2021

From a friendly user on Discord:

this line is wrong.
javaPath = "C:\\Program Files\\Java\\jdk1.8.0_271"

Because if i first run your jar on a Linux system, it needs to be able to say, "oh damn! I'm on Linux"
Of which you can then do
which java

and it will return a path to where the primary java is located, if you need a version, of that java you can get it from doing java -version or w/e the path was returned you know this last part I'm sure.
kreezxil@970AKRAIT:~/Software/ServerPackCreator$ which java /usr/bin/java
if you tackle the problem tho, you'll be more valuable to the crown tho.

@Griefed Griefed added bug Something isn't working enhancement New feature, request or improvement labels Feb 28, 2021
@Griefed Griefed self-assigned this Feb 28, 2021
@Griefed
Copy link
Owner Author

Griefed commented Feb 28, 2021

Fixed as of version 1.0.1

@Griefed Griefed closed this as completed Feb 28, 2021
@Griefed Griefed added this to Done in Issue Tracker Jul 13, 2021
@Griefed Griefed added the accepted Feature Ask which got accepted. label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Feature Ask which got accepted. bug Something isn't working enhancement New feature, request or improvement
Projects
No open projects
Issue Tracker
  
Done
Development

No branches or pull requests

1 participant