Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would someone like to take ownership of this project? #33

Open
aisthesis opened this issue Jan 7, 2020 · 18 comments
Open

Would someone like to take ownership of this project? #33

aisthesis opened this issue Jan 7, 2020 · 18 comments

Comments

@aisthesis
Copy link
Collaborator

This is a very useful library that should be easy to maintain. Necessary maintenance would just be to make the necessary changes if providers of financial data evolve over time (possibly adding new ones, deprecating obsolete ones, changing code to correspond to new APIs, although pandas updates should be taking care of this.

The library also offers some nice ML tools that I developed at first just for my own use.

Anyone actively using the library would be a good candidate to take it over. I haven't been using it for a couple of years, so don't even know firsthand any more if everything still works. It should, at least using the specified versions of everything. But I'm sure many of the dependencies already have new versions that should be supported.

I'll be happy to consult on any changes, but if anyone is still actively using the library, they would be well-served to take over the repo to keep it updated and perhaps even expand if you wish.

@prp1277
Copy link

prp1277 commented Feb 7, 2020

@aisthesis I just stumbled across this after thinking "Pynance would be a great library name".

I'm new to Python(and on mobile at the moment), but am very interested. I'll take a look when I get home tonight to see how I can help.

@prp1277
Copy link

prp1277 commented Feb 9, 2020

I looked over the codebase and I think am way too new to python to take something like this on.

I have a few ideas as far as new endpoints to use, such as iextrading & alpaca, but in terms of managing a library I would be in way over my head.

Learning python / pip / <insert package manager here> from a background in npm / yarn has been a real struggle (especially on Windows).

@GriffinAustin
Copy link
Owner

I've been using this library for quite some time now on my personal finance projects, and after taking a closer look at the codebase, I'd like to take this under my belt. I'm quite familiar with the libraries used as well as the data providers. I also have a few ideas and expansions for the ML tools.

I think @prp1277 will also bring some good modernization changes to the table. If you'd like to talk some more about your ideas, I think that'd be a good idea.

Let me know if this sounds like a good idea moving forward, @aisthesis, and if and/or how much you would like to continue to be a part of this awesome library!

@aisthesis
Copy link
Collaborator Author

I'd be delighted for you to take it under your belt. Let me know how I can help. The first thing that comes to mind would be getting pip install to point to your fork rather than mine.

@GriffinAustin
Copy link
Owner

That sounds like a good plan. I think the best way to go about this would be to add me as an owner on PyPI; my username is griffinaustin. Also, archiving this repository and linking to my fork in the description to show this one is deprecated would be a good thing to do.

As for moving forward with the project, I think we should start by updating the dependencies. This includes moving from matplotlib.finance, which is deprecated, to mplfinance as well as some others. I'll open an issue on my fork with more details so we can get started updating this project for 2020!

@aisthesis
Copy link
Collaborator Author

Hi Griffin, as you've no doubt observed, I haven't been active on here in a while. Would you still like me to add you as owner on PyPi?

That sounds like a good plan. I think the best way to go about this would be to add me as an owner on PyPI; my username is griffinaustin. Also, archiving this repository and linking to my fork in the description to show this one is deprecated would be a good thing to do.

As for moving forward with the project, I think we should start by updating the dependencies. This includes moving from matplotlib.finance, which is deprecated, to mplfinance as well as some others. I'll open an issue on my fork with more details so we can get started updating this project for 2020!

@aisthesis
Copy link
Collaborator Author

Feel free to PM me so I remember to do it this time.

@GriffinAustin
Copy link
Owner

Feel free to PM me so I remember to do it this time.

Hello @aisthesis, I am still interested in taking up this project so that does include adding me as owner.

@aisthesis
Copy link
Collaborator Author

Attempting to transfer ownership, I got a message "GriffinAustin/pynance" already exists. So, it may not have been successful.

@GriffinAustin
Copy link
Owner

GriffinAustin commented Jan 25, 2021

I deleted my fork if you want to give it another try. Moving forward with PyPI, do you want to add me as a maintainer? It seems that would be the easiest and best.

EDIT: It is showing me as collaborator so I assume we are good to go there.

@aisthesis
Copy link
Collaborator Author

It worked now adding you as actual owner. I'll presumably show up as collaborator.

Is your handle on PyPi also GriffinAustin? If so, you should have an invitation as collaborator.

@GriffinAustin
Copy link
Owner

Looks like we are good to go now! I look forward to helping revitalize this project.

@aisthesis
Copy link
Collaborator Author

Thank you, Griffin.

How about the documentation website? http://pynance.net/

@GriffinAustin
Copy link
Owner

I think it would be a good idea to migrate the documentation to readthedocs because we are currently using Sphinx.

@aisthesis
Copy link
Collaborator Author

Sounds good. The domain pynance.net is coming up for renewal. Is it ok for me to let it expire? Simply maintaining the domain doesn't cost much if there's a server you can point it to. The documentation currently appearing there was generated using Sphinx.

@GriffinAustin
Copy link
Owner

Yes, go ahead and let it expire and I will set up readthedocs with Sphinx

@aisthesis
Copy link
Collaborator Author

Just fyi: while the hosting of pynance.net will expire 3/2/2021, I have the domain until 3/2/22 in case you decide you'd like it in the meantime. Google Analytics has it currently with 135 users and around 25 hits daily.

@aisthesis
Copy link
Collaborator Author

I added you as maintainer on PyPI test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants