Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaData and "info" command #6

Merged
merged 7 commits into from Oct 15, 2022
Merged

MetaData and "info" command #6

merged 7 commits into from Oct 15, 2022

Conversation

GrizzlT
Copy link
Member

@GrizzlT GrizzlT commented Aug 29, 2022

It would be beneficial if there existed an info command that could display some stats about data in the intermediary format.

The protocol version, display name and optional note will be stored in a new struct called MetaData. This data will be stored under the field name metadata.

Things I'm thinking about:

  • protocol version
  • display name (defaults to protocol version if none is set)
  • optional note
  • amount of blocks and properties (per type)
  • healthcheck to make sure there are no gaps in blockstate ids

@taylorsk taylorsk self-assigned this Sep 18, 2022
@VixieTSQ VixieTSQ marked this pull request as draft October 13, 2022 17:45
Copy link
Member Author

@GrizzlT GrizzlT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't request changes, but lemme know what you think about my comments. :)

src/blocks/intermediary/data.rs Outdated Show resolved Hide resolved
src/blocks/intermediary/data.rs Outdated Show resolved Hide resolved
src/blocks/intermediary/rules.rs Outdated Show resolved Hide resolved
src/cmd/info.rs Outdated Show resolved Hide resolved
src/cmd/intermediary.rs Outdated Show resolved Hide resolved
@GrizzlT GrizzlT marked this pull request as ready for review October 15, 2022 20:03
@GrizzlT GrizzlT merged commit 564e1c4 into develop Oct 15, 2022
@GrizzlT GrizzlT deleted the feature/metadata branch October 15, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants