Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question #24

Open
atherdon opened this issue Jan 15, 2019 · 5 comments
Open

question #24

atherdon opened this issue Jan 15, 2019 · 5 comments
Labels
enhancement New feature or request low

Comments

@atherdon
Copy link
Member

atherdon commented Jan 15, 2019

at our Document layouts i see this line
but we don't have this files. Am i right that we didn't move them from showcase, right? or we don't need them

@vadim9999
Copy link
Collaborator

vadim9999 commented Jan 15, 2019

@atherdon We don't need them, because we passing styles from component DownloadPDFLink1 to DocumentLayout1
like this

<PDFDownloadLink
             document={DocumentLayout1(styles, this.props.name, this.props.data)}
             fileName={this.props.name + ".pdf"}>
               {({ blob, url, loading, error }) => (
                 loading ? 'Loading document...' : 'Download now!'
               )}
           </PDFDownloadLink>

@atherdon
Copy link
Member Author

understand.. so we have this styles imported to download button link, right?

@vadim9999
Copy link
Collaborator

yes, but it's doesn't change any styles of button

@atherdon
Copy link
Member Author

ok, i got it - imported at button, but styling documents. ok, we'll address this later. for now let's don't worry about it

@atherdon
Copy link
Member Author

thanks for clarification

@atherdon atherdon added enhancement New feature or request low labels Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

2 participants