-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump removes versionName identifier from build.gradle #2
Comments
@AlphaGit thx for opening this issue I'm gonna take a look into that as soon as I can! |
Oh, I think that I just have missed the react-native-cli-bump-version/src/index.ts Lines 140 to 145 in 49ad9ab
Looking at the react-native-cli-bump-version/src/index.ts Line 128 in 49ad9ab
I'm using gradle to get version names directly from Anyway, gonna fix that and also setup some tests |
Ops, wrongly closed |
@AlphaGit 1.0.3 released, can you confirm that it works? |
@Grohden I can confirm it's working perfectly. Thank you very much for such a quick turnaround! |
I'm gonna close it then, feel free to reopen if needed |
Hi! First of all, thanks for this wonderful tool -- it really comes in handy!
I've noticed that after running a version bump, the
versionName
identifier is removed from the build.gradle file.Say that these are my initial build.gradle contents:
I will run:
This is the final build.gradle:
Which in turns, makes the script fail on the next try, because it doesn't find the
versionName
identifier:I think this might simply be a wrong replacement in the regex. (If there is a chance, I might come back myself with a PR for this issue.)
Thanks again!
The text was updated successfully, but these errors were encountered: