Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fulmatch for regex matching. #182

Open
pranjaldoshi96 opened this issue Feb 27, 2021 · 1 comment
Open

Using fulmatch for regex matching. #182

pranjaldoshi96 opened this issue Feb 27, 2021 · 1 comment

Comments

@pranjaldoshi96
Copy link

pranjaldoshi96 commented Feb 27, 2021

Proposed Functionality

For regex matching, we are using re.match which only checks if the pattern/regex is present at the beginning of the string. But if that is the case then the name pattern sounds ambiguous cause it looks like we are defining a pattern and the input string should follow that pattern.

regex = '.*@domain.com'
pattern1 = 'name@domain.com' # this should match
pattern2 = 'name@domain.comSomethingElse'  #This should not match
@Grokzen
Copy link
Owner

Grokzen commented Feb 27, 2021

#183 For reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants