Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a 404 when the conversation id is not found #2

Open
GromNaN opened this issue Mar 6, 2023 · 0 comments
Open

Return a 404 when the conversation id is not found #2

GromNaN opened this issue Mar 6, 2023 · 0 comments

Comments

@GromNaN
Copy link
Owner

GromNaN commented Mar 6, 2023

Going to /conversation/1234 (where conversation with id 1234 does not exist), an error 404 is expected. Got 500.

public function mount(
string $id = null,
): void {
if ($id) {
// @todo catch not found exception
$this->conversation = $this->documentManager->find(Conversation::class, $id);
} else {
$this->conversation = new Conversation();
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant