Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Remove extra padding in alert dialog #188

Closed
edwardaux opened this issue Apr 4, 2022 · 0 comments 路 Fixed by #189
Closed

馃悰 Remove extra padding in alert dialog #188

edwardaux opened this issue Apr 4, 2022 · 0 comments 路 Fixed by #189
Labels
bug Something isn't working

Comments

@edwardaux
Copy link
Contributor

Description

This one is a minor UI glitch, but I don't have time to raise a PR at the moment (it'd be a good one for any new contributors)... when the suppress flag is set to null in the alert dialog, we end up with two SizedBox widgets in a row (which increases the padding at the bottom under the button).

image

This first SizedBox should be included in the if condition here

ie. it should look something like (untested):

if (suppress != null) ...[
  const SizedBox(height: 16),
  DefaultTextStyle(
    style: MacosTheme.of(context).typography.headline,
    child: suppress!,
  ),
],
const SizedBox(height: 16),

Steps To Reproduce

Show a MacosAlertDialog where suppress is set to null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant