Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 ToolBarDivider widget #231

Closed
whiplashoo opened this issue May 7, 2022 · 0 comments · Fixed by #234
Closed

💡 ToolBarDivider widget #231

whiplashoo opened this issue May 7, 2022 · 0 comments · Fixed by #234
Assignees
@whiplashoo

Comments

@whiplashoo
Copy link
Collaborator

Use case

A ToolBar should be able to show dividers (vertical lines) between the various toolbar items:

Screenshot 2022-05-07 at 11 12 44 PM

(from the Mail app).
@whiplashoo whiplashoo self-assigned this May 7, 2022
@whiplashoo whiplashoo mentioned this issue May 8, 2022
Merged
GroovinChip pushed a commit that referenced this issue May 8, 2022
@whiplashoo
Improve MacosTooltip, add tooltip property to toolbar items, and im…
cc87bb8 
…plement `ToolbarDivider` (closes #231, #232) (#234)
GroovinChip added a commit that referenced this issue May 8, 2022
@GroovinChip @whiplashoo
Version 1.2.0 (#235)
a2213ce 
* `MacosColorWell` docfix (#219)

* docs: fix color well docs

* chore: bump version & changelog

* Version 1.0.1 (#222)

* Display search results when searching from a `MacosSearchField` (closes #216) (#224)

* feat: implement showing suggestions below/above MacosSearchField

* refactor: set and clean up MacosSearchField properties

* chore: make offset method private

* refactor: remove expanded suggestions mode

* refactor: clean up and remove unnecessary properties

* refactor: add ability to supply onSelected callback to individual search suggestion items, extend example

* fix: show overlay at proper vertical offset

* chore: minor clean up of the fields page

* refactor: use MacosOverlayFilter for all frosted glass effects of menus and dropdowns

* chore: remove unnecessary imports

* docs: document MacosSearchField

* chore: explain how to retrieve searchKey property via onSuggestionSelected

* docs: document onChanged property

* feat: add MacosSearchFieldTheme

* chore: clean up MacosSearchFieldTheme

* test: add test for MacosSearchField

* test: add test for MacosSearchFieldTheme

* refactor: improve emptyWidget and fields example

* refactor: use results instead of suggestions

* docs: update README

* chore: update changelog and pubspec

* test: fix textual date picker test

* refactor: rename suggestionHeight to resultHeight

* Update CHANGELOG.md

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/theme/overlay_filter.dart

* Update lib/src/theme/overlay_filter.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update pubspec.yaml

* chore: run pub get

* chore: run flutter format lib

* refactor: remove height property from MacosOverlayFilter and add documentation

Co-authored-by: Reuben Turner <groovinchip@gmail.com>

* `CustomToolbarItem` widget  (#228)

* implement CustomToolbarItem widget

* chore: update README, changelog and pubspec

* test: fix date picker test

Co-authored-by: Reuben Turner <groovinchip@gmail.com>

* Version `1.1.0+1` - Readme updates (#233)

* Improve `MacosTooltip`, add tooltip property to toolbar items, and implement `ToolbarDivider` (closes #231, #232) (#234)

Co-authored-by: Minas Giannekas <whiplashoo@users.noreply.github.com>
GroovinChip added a commit that referenced this issue May 9, 2022
@GroovinChip @whiplashoo
Version 1.2.1 (#241)
01081c5 
* `MacosColorWell` docfix (#219)

* docs: fix color well docs

* chore: bump version & changelog

* Version 1.0.1 (#222)

* Display search results when searching from a `MacosSearchField` (closes #216) (#224)

* feat: implement showing suggestions below/above MacosSearchField

* refactor: set and clean up MacosSearchField properties

* chore: make offset method private

* refactor: remove expanded suggestions mode

* refactor: clean up and remove unnecessary properties

* refactor: add ability to supply onSelected callback to individual search suggestion items, extend example

* fix: show overlay at proper vertical offset

* chore: minor clean up of the fields page

* refactor: use MacosOverlayFilter for all frosted glass effects of menus and dropdowns

* chore: remove unnecessary imports

* docs: document MacosSearchField

* chore: explain how to retrieve searchKey property via onSuggestionSelected

* docs: document onChanged property

* feat: add MacosSearchFieldTheme

* chore: clean up MacosSearchFieldTheme

* test: add test for MacosSearchField

* test: add test for MacosSearchFieldTheme

* refactor: improve emptyWidget and fields example

* refactor: use results instead of suggestions

* docs: update README

* chore: update changelog and pubspec

* test: fix textual date picker test

* refactor: rename suggestionHeight to resultHeight

* Update CHANGELOG.md

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/fields/search_field.dart

* Update lib/src/theme/overlay_filter.dart

* Update lib/src/theme/overlay_filter.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update lib/src/theme/search_field_theme.dart

* Update pubspec.yaml

* chore: run pub get

* chore: run flutter format lib

* refactor: remove height property from MacosOverlayFilter and add documentation

Co-authored-by: Reuben Turner <groovinchip@gmail.com>

* `CustomToolbarItem` widget  (#228)

* implement CustomToolbarItem widget

* chore: update README, changelog and pubspec

* test: fix date picker test

Co-authored-by: Reuben Turner <groovinchip@gmail.com>

* Version `1.1.0+1` - Readme updates (#233)

* Improve `MacosTooltip`, add tooltip property to toolbar items, and implement `ToolbarDivider` (closes #231, #232) (#234)

* Fix toolbar `actions` RangeError (closes #239) (#240)

Co-authored-by: Minas Giannekas <whiplashoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whiplashoo whiplashoo

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@whiplashoo