New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement MacosTable #320
base: dev
Are you sure you want to change the base?
Conversation
This is awesome! @GroovinChip, is there something in the way for merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pithuene, and thank you for this PR! I'm excited to see a new widget being added, especially this one!
Please review the feedback I've left and implement the requested changes. Additionally, please update the CHANGELOG.md
file.
Thanks!
date_picker_test.dart was failing due to not accounting for going from January to December and vice-versa.
Hey @GroovinChip, thanks a lot for giving me feedback on my pull request! Thanks again for your time! |
I mean add an entry that describes what the new version adds or changes. If you look at the file you'll understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing - can you please post a screenshot of the table in dark mode? I want to make sure that it looks good with dark theme.
Also can you please run flutter format
on macos_table_datasource.dart
@pithuene looking forward for the merge! Can you maybe give me an example, how the ordering actually work? It seems, when I change the datasource like so:
The ordering gets messed up somehow. Can you help me here out. Thanks |
I can take a look @Yetispapa but I would need more context, its hard to tell much just from the code you've shown. |
@pithuene, thanks for the quick repsonse. Alright. Let me check it again. |
@pithuene anything new to report on this? |
@GroovinChip not yet. I've been too busy the last few weeks, might find the time next week though. |
No problem my dude, take your time. Your life comes first :) |
7b5ea17
to
10dda17
Compare
I implemented a
MacosTable
widget which looks similar to the macOSNSTableView
(adresses #262 and #199).The table features ordering by column and row selection.
I have also added some tests for the basic operations.
I am sure there is still a lot to improve, both in code and in UI, but I hope this can serve as a starting point.
This is a screenshot of the table widget running in a process monitor application I am building.
Note that this is running on linux and the font is not the one used on macOS.
Pre-launch Checklist
dartfmt
on all changed filesCHANGELOG.md
with my changes