New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacosTabView & MacosTab #206
Conversation
# Conflicts: # example/lib/main.dart
Codecov Report
@@ Coverage Diff @@
## dev #206 +/- ##
==========================================
+ Coverage 59.25% 65.00% +5.75%
==========================================
Files 56 47 -9
Lines 5016 4324 -692
==========================================
- Hits 2972 2811 -161
+ Misses 2044 1513 -531
Continue to review full report at Codecov.
|
* Minor API updates * Updated color values * Ensure Tab dividers get colored in correctly * Added/updated documentation * Sample app page fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andrewngabriel Thanks for your hard work on this feature. If you don't mind, though, I'd like you to rework the API to something that more resembles Flutter's material Tab
, TabBarView
and TabController
. I feel that the current API surface is too cumbersome. Setting the content of the body
to a particular widget on each tab click, as well as setting the active index, is too much.
MaosTabView
should take aList<Widget> children
and a controller used for showing the child based on the index of the widget in the list and the current index of the controllerMacosTab
itself should not be responding to clicks, the controller should be handling that.- When implemented an API like the above, don't worry about all the animation stuff - we don't need that here.
# Conflicts: # example/lib/main.dart
So.... Is it ready to use? I can't find example code. |
@dbsxdbsx No, it is not ready yet. I requested changes to this feature. Speaking of - @Andrewngabriel are you working on those changes? I could take a crack at it if you're too busy. |
Closing in favor of #273 |
Add Tabview
Closes #70
Demo:
tabview_demo.mov
Pre-launch Checklist
dartfmt
on all changed filesCHANGELOG.md
with my changes