Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found bugs, rebuild request #5

Open
Mihail-Afanasiev opened this issue Sep 28, 2016 · 1 comment
Open

Found bugs, rebuild request #5

Mihail-Afanasiev opened this issue Sep 28, 2016 · 1 comment

Comments

@Mihail-Afanasiev
Copy link

Mihail-Afanasiev commented Sep 28, 2016

I've found at least two bugs with achievements API:

  1. I can't use "setStepsAchievement" function. I've researched your code and found that there is difference in naming at calling it in Achievements.as class:
    _context.call("setStepsAchivement", achievementId,numSteps);
    and mapping it in ExtensionContext.java:
    functionMap.put("setStepsAchievement", new SetStepsAchievementFunction());
    Because of this I get an error that context doesn't have such method.
  2. IncrementAchievement() is not working. You has the following code:
    achievementId = arg1[0].getAsString();
    numSteps = arg1[0].getAsInt();
    As you can see you take element with 0 index twice. So the second parameter numSteps just has no sense.

Please can you please fix it and rebuild the ane?
I'm not familiar with github and have no experience in building ane but anyway I will try to make it by myself. But if thi repo is alive and you'll make it faster than me, I'd be glad.

Thanks for ane anyway!

@Mihail-Afanasiev
Copy link
Author

I've check it out and found the same problem in SetStepsAchievementFunction.java as in IncrementAchievementFunction.java.
Double usage of 0-index argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant