Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open with URL includes trailing single quote (invalid URL) #1624

Closed
saildata opened this issue Jul 10, 2019 · 1 comment · Fixed by #1900
Closed

Open with URL includes trailing single quote (invalid URL) #1624

saildata opened this issue Jul 10, 2019 · 1 comment · Fixed by #1900

Comments

@saildata
Copy link

Describe the bug
If a URL in guake is wrapped in single quotes, the "open with URL" context menu opens the browser with one trailing single quote.

Expected behavior
...opens the browser without the original surrounding quotes.

Actual behavior
The single quote is included -> HTTP 404.

To Reproduce

  1. $ echo "'https://wiki.archlinux.org/'"
  2. Right click on the link and open link/open URL.

img1233


$ guake --support

Guake Version: 3.6.3

Vte Version: 0.56.3

Vte Runtime Version: 0.56.3


GTK+ Version: 3.24.10

GDK Backend: GdkX11.X11Display


Desktop Session: 2b_flat-remix-dark-gnome-fullpanel


Display: :0

RGBA visual: True

Composited: True

  • Monitor: 0 - DP-4
    • Geometry: 1920 x 1080 % 2 at 0, 0
    • Size: 600 x 340 mm²
    • Primary: True
    • Refresh rate: 60.00 Hz
    • Subpixel layout: unknown
@andrzejkupczyk
Copy link

andrzejkupczyk commented Nov 10, 2020

Same thing with brackets and probably with other chars as well. This is quite annoying.

$ echo "ERROR: MissingImmutableAnnotation (see https://psalm.dev/213)"

Clicking on the link opens page https://psalm.dev/213) in a browser.

$ guake --support Guake Version: 3.6.3

Vte Version: 0.60.3

Vte Runtime Version: 0.60.3


GTK+ Version: 3.24.20

GDK Backend: GdkX11.X11Display


Desktop Session: gnome-xorg


Display: :1

RGBA visual: True

Composited: True

  • Monitor: 0 - SEC LVDS-1-1
    • Geometry: 1366 x 768 at 1200, 374
    • Size: 344 x 194 mm²
    • Primary: True
    • Refresh rate: 60.09 Hz
    • Subpixel layout: horizontal-rgb
  • Monitor: 1 - DEL HDMI-1-1
    • Geometry: 1200 x 1600 at 0, 0
    • Size: 367 x 275 mm²
    • Primary: False
    • Refresh rate: 60.00 Hz
    • Subpixel layout: unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants