Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined colour palettes #1766

Open
gchamon opened this issue May 28, 2020 · 5 comments
Open

User defined colour palettes #1766

gchamon opened this issue May 28, 2020 · 5 comments

Comments

@gchamon
Copy link

gchamon commented May 28, 2020

I have looked for similar feature requests, but I couldn't find any. In other terminals, you can install extra colour palettes in a predefined config folder. For instance, konsole has a .colorscheme file type that when deployed under $XDG_DATA_HOME/konsole/ will appear in the selection menu.

I would like to implement something like this for guake. I could extend palletes.py to look for theme files in a directory and import them. I would suggest a JSON structure that resembles the internal structure of PALETTES in guake/palettes.py, something like:

{
    "<SCHEME-NAME>": "<SCHEME>"
}

For instance, I love snazzy for konsole, and I ported it manually, but I would like to have a file like ~/.config/guake/themes/snazzy.json with the configuration, so that I could play around with other schemes and go back to my custom scheme without losing it.

I can open a prototypical pull request to illustrate what I want, if that is of interest.

Thanks!

@lgarczyn
Copy link

lgarczyn commented May 6, 2021

Would enjoy this feature. My whole desktop uses arc-dark, and I would enjoy if my terminal would too, even gnome terminal supports this.

@gchamon
Copy link
Author

gchamon commented May 6, 2021

@lgarczyn I just migrated to yakuake + KDE. Guake is an awesome project and I would have loved to continue using it, but between problems, lack of features and not hearing from maintainers I just moved on.

Still, my PR implements a perfectly functional user-defined themes prototype, if you are feeling adventurous.

@lgarczyn
Copy link

lgarczyn commented May 6, 2021

Thanks, sadly all the alternatives come with their drawbacks. Might try your solution.

@Davidy22
Copy link
Collaborator

Going back through the log, looks like this is closely related to #220, leaving this here to make the link.

@gchamon
Copy link
Author

gchamon commented Sep 17, 2021

@Davidy22 indeed, user defined and custom pallets are closely related. Good job! Nice to see guake getting some well-deserved love. Kudos to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants