Some shortcut keys are abnormal

[YHYJ]

Describe the bug

Some shortcut keys are abnormal:

1. switch-tab, close-tab and close-terminal do not respond
2. zoom-in and zoom-out are reversed

Expected behavior

All shortcut keys perform their duties.

Actual behavior

Some shortcut keys are normal, some shortcut keys do not respond, and some shortcut keys are reversed.

To Reproduce

Only upgrade from 3.7.0 to 3.8.0.

---

$ guake --support

Guake Version: 3.8.0

Vte Version: 0.66.0

Vte Runtime Version: 0.66.0

---

GTK+ Version: 3.24.30

GDK Backend: <GdkX11.X11Display

---

Desktop Session: i3

---

Display: :0

RGBA visual: True

Composited: True

• Monitor: 0 - BOE eDP1
  • Geometry: 1920 x 1080 at 0, 0
  • Size: 340 x 190 mm²
  • Primary: True
  • Refresh rate: 60.026 Hz
  • Subpixel layout: unknown

[Davidy22]

Guake 3.8 revamped keyboard shortcut code to enable CTRL+tab in keyboard shortcuts. The default shortcut for next and previous tab was changed to CTRL+tab and CTRL+SHIFT+tab. For the others, what keyboard binding are those shortcuts assigned to and are you using a non US keyboard layout?

[YHYJ]

Now I set the keyboard layout to US, but the shortcut keys are still abnormal

   System Locale: LANG=en_US.UTF-8
       VC Keymap: us
      X11 Layout: us
       X11 Model: pc105+inet
     X11 Options: terminate:ctrl_alt_bksp

I don't want to use the next and previous tab shortcuts, I like to switch tabs according to the number.

The following is my shortcut key binding:

guake configuration

[keybindings/global]
show-hide='F1'

[keybindings/local]
clipboard-copy='<Primary><Shift>c'
close-tab='<Primary><Alt>q'
close-terminal='<Alt>F4'
decrease-height='disabled'
decrease-transparency='disabled'
focus-terminal-down='<Alt>Down'
focus-terminal-left='<Alt>Left'
focus-terminal-right='<Alt>Right'
focus-terminal-up='disabled'
increase-height='disabled'
increase-transparency='disabled'
move-tab-left='disabled'
move-tab-right='disabled'
new-tab='<Primary><Shift>t'
new-tab-home='disabled'
next-tab='<Primary>Tab'
previous-tab='<Primary><Shift>Tab'
quit='<Shift><Super>g'
rename-current-tab='disabled'
split-tab-horizontal='<Primary><Shift>h'
split-tab-vertical='<Primary><Shift>j'
switch-tab-last='disabled'
switch-tab1='<Alt>1'
switch-tab10='<Alt>0'
switch-tab2='<Alt>2'
switch-tab3='<Alt>3'
switch-tab4='<Alt>4'
switch-tab5='<Alt>5'
switch-tab6='<Alt>6'
switch-tab7='<Alt>7'
switch-tab8='<Alt>8'
switch-tab9='<Alt>9'
toggle-fullscreen='disabled'
toggle-hide-on-lose-focus='disabled'
toggle-transparency='disabled'
zoom-in='<Primary>minus'
zoom-in-alt='disabled'
zoom-out='<Primary>equal'

[Davidy22]

Your zoom in/out keys probably feel like they're reversed because of these two settings:

zoom-in='<Primary>minus'
zoom-out='<Primary>equal'

It might feel more natural if you flip these around. The guake default should also be this, but reversed.

The numbered switch tab shortcuts seem to work, but they're all offset by one.

Close tab doesn't close tab, as described. On more investigation, it looks like all CTRL+ALT keybindings are unresponsive.

Close terminal shortcut worked with alt+f4, but that may have just been the default desktop behavior for the keybinding. On more investigation, looks like the function for close terminal just doesn't work.

Will update when I get a fix in for this.

[YHYJ]

About zoom in/out keys, what I set in the preferences is correct, but what I print out with guake --save-preferences is the opposite of my setting, which seems to be a bug.

[Davidy22]

Still unable to reproduce the zoom swap, but attached pull request should fix the other keyboard shortcut issues.

[YHYJ]

Can you tell me where the guake configuration information is stored, I still use the original configuration after reinstalling guake, thanks.

[Davidy22]

Our org.guake.gschema.xml file contains the defaults, we don't yet have a reset default option but we have an issue open and there was a WIP patch posted in there.

[YHYJ]

Uh, I didn’t make it clear. What I want to know is how to restore guake to its default configuration. After I reinstall guake, it still uses my modified configuration.

[Davidy22]

Yeah, we don't have a nice button for that but there's some work happening issue #1872 towards it, looks like it got dropped halfway but if you want to finish what the guy started then we'll have a nice clean settings reset button. Otherwise, I think you can accomplish what you want by cleaning out entries in dconf editor

[YHYJ]

Sorry, I'm not sure I have time to do this.